Hi Dave, kernel test robot noticed the following build warnings: [auto build test WARNING on brauner-vfs/vfs.all] [also build test WARNING on xfs-linux/for-next axboe-block/for-next linus/master v6.12-rc1 next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dave-Chinner/vfs-replace-invalidate_inodes-with-evict_inodes/20241002-094254 base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all patch link: https://lore.kernel.org/r/20241002014017.3801899-4-david%40fromorbit.com patch subject: [PATCH 3/7] vfs: convert vfs inode iterators to super_iter_inodes_unsafe() config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20241004/202410041848.j3wt7yFP-lkp@xxxxxxxxx/config) compiler: or1k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410041848.j3wt7yFP-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410041848.j3wt7yFP-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/inode.c:874: warning: Function parameter or struct member 'inode' not described in 'evict_inode_fn' >> fs/inode.c:874: warning: Function parameter or struct member 'data' not described in 'evict_inode_fn' >> fs/inode.c:874: warning: expecting prototype for evict_inodes(). Prototype was for evict_inode_fn() instead vim +874 fs/inode.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 863 63997e98a3be68 Al Viro 2010-10-25 864 /** 63997e98a3be68 Al Viro 2010-10-25 865 * evict_inodes - evict all evictable inodes for a superblock 63997e98a3be68 Al Viro 2010-10-25 866 * @sb: superblock to operate on 63997e98a3be68 Al Viro 2010-10-25 867 * 63997e98a3be68 Al Viro 2010-10-25 868 * Make sure that no inodes with zero refcount are retained. This is 1751e8a6cb935e Linus Torvalds 2017-11-27 869 * called by superblock shutdown after having SB_ACTIVE flag removed, 63997e98a3be68 Al Viro 2010-10-25 870 * so any inode reaching zero refcount during or after that call will 63997e98a3be68 Al Viro 2010-10-25 871 * be immediately evicted. ^1da177e4c3f41 Linus Torvalds 2005-04-16 872 */ f3df82b20474b6 Dave Chinner 2024-10-02 873 static int evict_inode_fn(struct inode *inode, void *data) ^1da177e4c3f41 Linus Torvalds 2005-04-16 @874 { f3df82b20474b6 Dave Chinner 2024-10-02 875 struct list_head *dispose = data; 250df6ed274d76 Dave Chinner 2011-03-22 876 250df6ed274d76 Dave Chinner 2011-03-22 877 spin_lock(&inode->i_lock); f3df82b20474b6 Dave Chinner 2024-10-02 878 if (atomic_read(&inode->i_count) || f3df82b20474b6 Dave Chinner 2024-10-02 879 (inode->i_state & (I_NEW | I_FREEING | I_WILL_FREE))) { 250df6ed274d76 Dave Chinner 2011-03-22 880 spin_unlock(&inode->i_lock); f3df82b20474b6 Dave Chinner 2024-10-02 881 return INO_ITER_DONE; 250df6ed274d76 Dave Chinner 2011-03-22 882 } 63997e98a3be68 Al Viro 2010-10-25 883 63997e98a3be68 Al Viro 2010-10-25 884 inode->i_state |= I_FREEING; 02afc410f363f9 Dave Chinner 2011-03-22 885 inode_lru_list_del(inode); 250df6ed274d76 Dave Chinner 2011-03-22 886 spin_unlock(&inode->i_lock); f3df82b20474b6 Dave Chinner 2024-10-02 887 list_add(&inode->i_lru, dispose); ac05fbb4006241 Josef Bacik 2015-03-04 888 ac05fbb4006241 Josef Bacik 2015-03-04 889 /* f3df82b20474b6 Dave Chinner 2024-10-02 890 * If we've run long enough to need rescheduling, abort the f3df82b20474b6 Dave Chinner 2024-10-02 891 * iteration so we can return to evict_inodes() and dispose of the f3df82b20474b6 Dave Chinner 2024-10-02 892 * inodes before collecting more inodes to evict. ac05fbb4006241 Josef Bacik 2015-03-04 893 */ f3df82b20474b6 Dave Chinner 2024-10-02 894 if (need_resched()) f3df82b20474b6 Dave Chinner 2024-10-02 895 return INO_ITER_ABORT; f3df82b20474b6 Dave Chinner 2024-10-02 896 return INO_ITER_DONE; ac05fbb4006241 Josef Bacik 2015-03-04 897 } 63997e98a3be68 Al Viro 2010-10-25 898 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
