On Thu, Oct 3, 2024 at 12:40 AM Ryusuke Konishi wrote: > > On Thu, Oct 3, 2024 at 12:00 AM Matthew Wilcox (Oracle) wrote: > > > > After "nilfs2: Convert nilfs_copy_buffer() to use folios", there are > > only a few remaining users of struct page in all of nilfs2, and they're > > straightforward to remove. Build tested only. > > Thank you for your ongoing work on converting to folio-based. > > Page structure references still remain in other files, but I'm > preparing a patch set to convert them to be folio-based, so together > with that, I think we'll be able to remove most of the page references > in nilfs2 in the next cycle. > > I'll check out this patch set. > > Thanks, > Ryusuke Konishi I've added comments to each patch based on my review and testing. The biggest comment is about the kernel panic caused by patches 1/4 and 4/4. As I wrote in my reply to each of them, this can be fixed by replacing "buffer_migrate_folio" with "buffer_migrate_folio_norefs". If you are busy and don't mind, I can fix the points I commented on. If so, please let me know. Or if you send me the v2 patchset, I'll check it again and add it to the patches I'll send upstream for the next cycle. Thanks, Ryusuke Konishi
