Re: [PATCH 41/41] union-mount: Add support for rename by __union_copyup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In message <1256152779-10054-42-git-send-email-vaurora@xxxxxxxxxx>, Valerie Aurora writes:
> From: Jan Blunck <jblunck@xxxxxxxxxxxxx>
> 
> It is possible to use __union_copyup() to support rename of regular files
> without returning -EXDEV.
> 
> XXX - Rewrite as copyup to old name followed by rename() + whiteout()

All this code just to support rename by copyup?!  I can see why we're
looking for other tricks, such as symlinks...

> Signed-off-by: Jan Blunck <jblunck@xxxxxxxxxxxxx>
> Signed-off-by: Valerie Aurora <vaurora@xxxxxxxxxx>

> +//	error = hash_lookup_union(&oldnd, &oldnd.last, &old);
> +	error = lookup_rename_source(&oldnd, &newnd, &trap, &oldnd.last, &old);

> +//	if (is_unionized(newnd.path.dentry, newnd.path.mnt))
> +//		goto exit5;

Nuke.

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux