On Thu, Sep 26, 2024 at 06:58:10PM +0000, Benno Lossin wrote: > On 26.09.24 16:58, Alice Ryhl wrote: > > A misc device is generally the best place to start with your first Rust > > driver, so having abstractions for miscdevice in Rust will be important > > for our ability to teach Rust to kernel developers. > > Sounds good! > > > I intend to add a sample driver using these abstractions, and I also > > intend to use it in Rust Binder to handle the case where binderfs is > > turned off. > > > > I know that the patchset is still a bit rough. It could use some work on > > the file position aspect. But I'm sending this out now to get feedback > > on the overall approach. > > > > This patchset depends on files [1] and vma [2]. > > > > Link: https://lore.kernel.org/all/20240915-alice-file-v10-0-88484f7a3dcf@xxxxxxxxxx/ [1] > > Link: https://lore.kernel.org/all/20240806-vma-v5-1-04018f05de2b@xxxxxxxxxx/ [2] > > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> > > --- > > Alice Ryhl (3): > > rust: types: add Opaque::try_ffi_init > > rust: file: add f_pos and set_f_pos > > rust: miscdevice: add abstraction for defining miscdevices > > I recall that we had a sample miscdev driver in the old rust branch. Can > you include that in this series, or is there still some stuff missing? I > think it would be really useful for people that want to implement such a > driver to have something to look at. I agree, I'll dig that up after -rc1 is out and add it to this series. thanks, greg k-h