Em 24 de setembro de 2024 23:40:27 GMT+02:00, Gabriel Krisman Bertazi <gabriel@xxxxxxxxxx> escreveu: >André Almeida <andrealmeid@xxxxxxxxxx> writes: > >> Hey! >> >> On 9/23/24 19:34, Gabriela Bittencourt wrote: >>> Instead of creating 'test' functions, use kunit functions to test >>> utf-8 support in unicode subsystem. >> >> I think it would be nice to explain in the commit message what are the >> benefits of this change, why refactoring into KUnit is a good idea? > >TBH, I wouldn't mind dropping this code altogether. We have similar >coverage in fstests already. It was useful when developing fs/unicode >but nowadays, it seems moot. > I see, I still find it useful when doing Unicode changes. Even if userspace tests show that something is broken, unit testing might be more precise in that regard. I'm sure David also has some good arguments about that matter too :D
