You can also add "Tested-by: Steve French <stfrench@xxxxxxxxxxxxx>"
On Tue, Sep 17, 2024 at 1:01 PM Paulo Alcantara <pc@xxxxxxxxxxxxx> wrote:
>
> David Howells <dhowells@xxxxxxxxxx> writes:
>
> > The cifs flag CIFS_INO_MODIFIED_ATTR, which indicates that the mtime and
> > ctime need to be written back on close, got taken over by netfs as
> > NETFS_ICTX_MODIFIED_ATTR to avoid the need to call a function pointer to
> > set it.
> >
> > The flag gets set correctly on buffered writes, but doesn't get set by
> > netfs_page_mkwrite(), leading to occasional failures in generic/080 and
> > generic/215.
> >
> > Fix this by setting the flag in netfs_page_mkwrite().
> >
> > Fixes: 73425800ac94 ("netfs, cifs: Move CIFS_INO_MODIFIED_ATTR to netfs_inode")
> > Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-lkp/202409161629.98887b2-oliver.sang@xxxxxxxxx
> > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> > cc: Jeff Layton <jlayton@xxxxxxxxxx>
> > cc: Steve French <sfrench@xxxxxxxxx>
> > cc: Paulo Alcantara <pc@xxxxxxxxxxxxx>
> > cc: linux-cifs@xxxxxxxxxxxxxxx
> > cc: netfs@xxxxxxxxxxxxxxx
> > cc: linux-fsdevel@xxxxxxxxxxxxxxx
> > ---
> > fs/netfs/buffered_write.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Reviewed-by: Paulo Alcantara (Red Hat) <pc@xxxxxxxxxxxxx>
>
--
Thanks,
Steve
