On Mon 16-09-24 13:26:19, Eric Sandeen wrote: > Convert the affs filesystem to use the new mount API. > Tested by comparing random mount & remount options before and after > the change. > > Cc: David Sterba <dsterba@xxxxxxxx> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Just one nit, otherwise feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> > + case Opt_verbose: > + affs_set_opt(ctx->mount_flags, SF_VERBOSE); > + break; > + case Opt_volume: { I guess there's no need for the braces anymore? > + strscpy(ctx->volume, param->string, 32); > + break; > } Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR