On 8/26/24 12:30 AM, NeilBrown wrote: > bd_prepare_to_claim() waits for a var to change, not for a bit to be > cleared. > So change from bit_waitqueue() to __var_waitqueue() and correspondingly > use wake_up_var(). > This will allow a future patch which change the "bit" function to expect > an "unsigned long *" instead of "void *". Looks fine to me - since this one is separate from the series, I can snag it and shove it into the block side so it'll make 6.12-rc1. Then at least it won't be a dependency for the rest of the series post that. -- Jens Axboe