Hi Greg,
On 2024/9/17 01:51, Greg KH wrote:
On Mon, Sep 16, 2024 at 09:56:13PM +0800, Yiyang Wu wrote:
Introduce Errno to Rust side code. Note that in current Rust For Linux,
Errnos are implemented as core::ffi::c_uint unit structs.
However, EUCLEAN, a.k.a EFSCORRUPTED is missing from error crate.
Since the errno_base hasn't changed for over 13 years,
This patch merely serves as a temporary workaround for the missing
errno in the Rust For Linux.
Why not just add the missing errno to the core rust code instead? No
need to define a whole new one for this.
I've discussed with Yiyang about this last week. I also tend to avoid
our own errno.
The main reason is that Rust errno misses EUCLEAN error number. TBH, I
don't know why not just introduces all kernel supported errnos for Rust
in one shot.
I guess just because no Rust user uses other errno? But for errno
cases, I think it's odd for users to add their own errno.
Thanks,
Gao Xiang
thanks,
greg k-h
