On Mon, Sep 16, 2024 at 09:56:12PM +0800, Yiyang Wu wrote: > diff --git a/fs/erofs/rust/erofs_sys.rs b/fs/erofs/rust/erofs_sys.rs > new file mode 100644 > index 000000000000..0f1400175fc2 > --- /dev/null > +++ b/fs/erofs/rust/erofs_sys.rs > @@ -0,0 +1,22 @@ > +#![allow(dead_code)] > +// Copyright 2024 Yiyang Wu > +// SPDX-License-Identifier: MIT or GPL-2.0-or-later Sorry, but I have to ask, why a dual license here? You are only linking to GPL-2.0-only code, so why the different license? Especially if you used the GPL-2.0-only code to "translate" from. If you REALLY REALLY want to use a dual license, please get your lawyers to document why this is needed and put it in the changelog for the next time you submit this series when adding files with dual licenses so I don't have to ask again :) thanks, greg k-h