Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > Could we please just remove that whole 'was_async' case entirely, and > just make the cres->ops->read() path just do a workqueue (which seems > to be what the true case does anyway)? > > So then the netfs_read_subreq_terminated() wouldn't need to take that > pointless argument, with the only case of async use just fixing > itself? Wouldn't that be cleaner? It's probably a good idea, but there's also erofs, which also goes through cachefiles_read() with it's own async callback which complicates things a little. David