On Fri, 13 Sept 2024 at 13:05, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Fri, Sep 13, 2024 at 12:50 PM Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote: > > - res = -EOPNOTSUPP; > > - if (!file->f_op->read_iter || !file->f_op->write_iter) > > - goto out_fput; > > - > > FWIW, I have made those sanity checks opt-in in my > fuse-backing-inode-wip branch: > https://github.com/amir73il/linux/commit/24c9a87bb11d76414b85960c0e3638a655a9c9a1 > > But that could be added later. This is the wrong place to check the f_op. We could do it in backing_file_open(), but this isn't going to be a common error, so I guess just returning an error at read/write time is also okay. Thanks, Miklos
