Jamie Lokier wrote: > Jan Blunck wrote: > > osst_read()/osst_write() modify file->f_pos directly instead of the ppos > > given to them. The VFS later updates the file->f_pos and overwrites it > > with the value of ppos. > > I notice st.c doesn't use or update file->f_pos (or *ppos), so > userspace probably won't be caring about f_pos from osst.c (they're > both SCSI tape drivers). And osst.c doesn't use the value, it just > increases it with each transfer. It doesn't even reset the value to > zero when rewinding the tape, so it's not that meaningful. > > So how about just removing those modifications to file->f_pos from osst.c? Or alternatively, perhaps they are missing from st.c. I don't know, but userspace can't have been all that dependent on the value :-) -- Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
