On Wed, Sep 04, 2024 at 10:16:17AM GMT, Vlastimil Babka wrote: > On 9/3/24 16:20, Christian Brauner wrote: > > Now that we pass down struct kmem_cache_args to calculate_sizes() we > > don't need it anymore. > > Nit: that sounds like a previous patch did the "pass down" part? Fine to do > both at once but maybe adjust description that we do both here? Hm, maybe that was misleadingly phrased but my intention was to express that this patch passes it down and removes the now unneeded member from struct kmem_cache. I've rephrased this to: "Pass down struct kmem_cache_args to calculate_sizes() so we can use args->{use}_freeptr_offset directly. This allows us to remove ->rcu_freeptr_offset from struct kmem_cache." on the work.kmem_cache_args branch.