On Fri, Aug 30, 2024 at 3:49 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Fri, 30 Aug 2024 at 12:57, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > On Thu, Aug 29, 2024 at 08:58:55PM GMT, Miklos Szeredi wrote: > > > On Thu, 29 Aug 2024 at 19:41, Aleksandr Mikhalitsyn > > > <aleksandr.mikhalitsyn@xxxxxxxxxxxxx> wrote: > > > > > > > Let's think about it a bit more and if you confirm that we want to go > > > > this way, then I'll rework my patches. > > > > > > And ACK from Christian would be good. > > > > Yeah, that all sounds good to me. I think Alex just followed the > > cephfs precedent. > > Okay, so please drop this patchset from your tree, then I'll have a > chance to review when Alex resends it. Dear friends, v4 is ready https://lore.kernel.org/all/20240903151626.264609-1-aleksandr.mikhalitsyn@xxxxxxxxxxxxx and tested with virtiofsd: # ./check -g idmapped FSTYP -- virtiofs PLATFORM -- Linux/x86_64 ubuntu 6.11.0-rc6+ #21 SMP PREEMPT_DYNAMIC Tue Sep 3 16:48:58 CEST 2024 generic/633 1s ... 1s generic/644 0s ... 0s generic/645 19s ... 18s generic/656 1s ... 1s generic/689 0s ... 0s generic/696 [not run] this test requires a valid $SCRATCH_DEV generic/697 0s ... 0s generic/698 [not run] this test requires a valid $SCRATCH_DEV generic/699 [not run] this test requires a valid $SCRATCH_DEV Ran: generic/633 generic/644 generic/645 generic/656 generic/689 generic/696 generic/697 generic/698 generic/699 Not run: generic/696 generic/698 generic/699 Passed all 9 tests Kind regards, Alex > > Thanks, > Miklos