On Tue, Sep 03, 2024 at 01:30:10PM GMT, Jan Kara wrote: > On Fri 30-08-24 15:04:48, Christian Brauner wrote: > > Make generic_file_llseek_size() use must_set_pos(). We'll use > > must_set_pos() in another helper in a minutes. Remove __maybe_unused > > from must_set_pos() now that it's used. > > > > Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx> > > Frankly, it would have been a bit easier to review for me if 6 & 7 patches > were together as one code refactoring patch... Yeah, I had it that way but the resulting diff was really difficult to read. I could've probably tried to use a different diff algorithm but this way was easier. > > > + guard(spinlock)(&file->f_lock); > > You really love guards, don't you? :) Frankly, in this case I don't see the Yes. :) > point and it makes my visual pattern matching fail but I guess I'll get > used to it. Feel free to add: I can remove it. I don't mind.
