On Wed, Nov 18, 2009 at 04:26:55PM +0800, Wu Fengguang wrote: > No one is calling wb_writeback and write_cache_pages with > wbc.nonblocking=1 any more. And lumpy pageout will want to do > nonblocking writeback without the congestion wait. .... > --- linux.orig/fs/xfs/linux-2.6/xfs_aops.c 2009-11-06 09:22:35.000000000 +0800 > +++ linux/fs/xfs/linux-2.6/xfs_aops.c 2009-11-06 09:52:21.000000000 +0800 > @@ -908,12 +908,8 @@ xfs_convert_page( > > bdi = inode->i_mapping->backing_dev_info; > wbc->nr_to_write--; > - if (bdi_write_congested(bdi)) { > - wbc->encountered_congestion = 1; bdi is unused now, so can be removed as well. Otherwise looks fine. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html