Re: [PATCH v4 14/16] bcachefs: add pre-content fsnotify hook to fault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 29, 2024 at 08:46:07AM GMT, Josef Bacik wrote:
> On Thu, Aug 29, 2024 at 07:26:42AM -0400, Kent Overstreet wrote:
> > On Thu, Aug 29, 2024 at 01:10:55PM GMT, Jan Kara wrote:
> > > On Wed 14-08-24 17:25:32, Josef Bacik wrote:
> > > > bcachefs has its own locking around filemap_fault, so we have to make
> > > > sure we do the fsnotify hook before the locking.  Add the check to emit
> > > > the event before the locking and return VM_FAULT_RETRY to retrigger the
> > > > fault once the event has been emitted.
> > > > 
> > > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
> > > 
> > > Looks good to me. Would be nice to get ack from bcachefs guys. Kent?
> > 
> > I said I wanted the bcachefs side tested, and offered Josef CI access
> > for that - still waiting to hear from him.
> 
> My bad I thought I had responded.  I tested bcachefs, xfs, ext4, and btrfs with
> my tests.  I'll get those turned into fstests today/tomorrow.  Thanks,

Acked-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux