Re: [PATCH v5 2/2] fuse: add default_request_timeout and max_request_timeout sysctls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2024 at 2:52 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Joanne,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on mszeredi-fuse/for-next]
> [also build test ERROR on linus/master v6.11-rc5 next-20240827]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Joanne-Koong/fuse-add-optional-kernel-enforced-timeout-for-requests/20240827-043354
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
> patch link:    https://lore.kernel.org/r/20240826203234.4079338-3-joannelkoong%40gmail.com
> patch subject: [PATCH v5 2/2] fuse: add default_request_timeout and max_request_timeout sysctls
> config: arc-randconfig-002-20240827 (https://download.01.org/0day-ci/archive/20240828/202408280419.yuu33o7t-lkp@xxxxxxxxx/config)
> compiler: arceb-elf-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240828/202408280419.yuu33o7t-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408280419.yuu33o7t-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> >> fs/fuse/sysctl.c:30:5: error: redefinition of 'fuse_sysctl_register'
>       30 | int fuse_sysctl_register(void)
>          |     ^~~~~~~~~~~~~~~~~~~~
>    In file included from fs/fuse/sysctl.c:9:
>    fs/fuse/fuse_i.h:1495:19: note: previous definition of 'fuse_sysctl_register' with type 'int(void)'
>     1495 | static inline int fuse_sysctl_register(void) { return 0; }
>          |                   ^~~~~~~~~~~~~~~~~~~~
> >> fs/fuse/sysctl.c:38:6: error: redefinition of 'fuse_sysctl_unregister'
>       38 | void fuse_sysctl_unregister(void)
>          |      ^~~~~~~~~~~~~~~~~~~~~~
>    fs/fuse/fuse_i.h:1496:20: note: previous definition of 'fuse_sysctl_unregister' with type 'void(void)'
>     1496 | static inline void fuse_sysctl_unregister(void) { return; }
>          |                    ^~~~~~~~~~~~~~~~~~~~~~
>

I see. In the Makefile, the sysctl.o needs to be gated by CONFIG_SYSCTL
eg
fuse-$(CONFIG_SYSCTL) += sysctl.o

I'll wait a bit to see if there are more comments on this patchset
before submitting v6.

>
> vim +/fuse_sysctl_register +30 fs/fuse/sysctl.c
>
>     29
>   > 30  int fuse_sysctl_register(void)
>     31  {
>     32          fuse_table_header = register_sysctl("fs/fuse", fuse_sysctl_table);
>     33          if (!fuse_table_header)
>     34                  return -ENOMEM;
>     35          return 0;
>     36  }
>     37
>   > 38  void fuse_sysctl_unregister(void)
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux