On Wed 21-08-24 14:54:56, Hongbo Li wrote:
> list_head can be initialized automatically with LIST_HEAD()
> instead of calling INIT_LIST_HEAD().
>
> Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/buffer.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index e55ad471c530..31a9062cad7e 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -774,12 +774,11 @@ EXPORT_SYMBOL(block_dirty_folio);
> static int fsync_buffers_list(spinlock_t *lock, struct list_head *list)
> {
> struct buffer_head *bh;
> - struct list_head tmp;
> struct address_space *mapping;
> int err = 0, err2;
> struct blk_plug plug;
> + LIST_HEAD(tmp);
>
> - INIT_LIST_HEAD(&tmp);
> blk_start_plug(&plug);
>
> spin_lock(lock);
> --
> 2.34.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
