Hi Josef, On 8/27/24 22:45, Josef Bacik wrote: > Hello, > > This is a prep series for my work to enable large folios on fuse. It has two > dependencies, one is Joanne's writeback clean patches > > https://lore.kernel.org/linux-fsdevel/20240826211908.75190-1-joannelkoong@xxxxxxxxx/ > > and an iomap patch to allow us to pass the file through the buffered write path > > https://lore.kernel.org/linux-fsdevel/7f55c7c32275004ba00cddf862d970e6e633f750.1724755651.git.josef@xxxxxxxxxxxxxx/ > > I've run these through an fstests run with passthrough_hp --direct-io, > everything looks good. why with --direct-io? It is not exactly O_DIRECT, but also not that far away - don't you want to stress read-ahead and page cache usage on write? I typically run with/without --direct-io, but disable passthrough. Thanks, Bernd