On Fri 16-08-24 14:38:49, Hongbo Li wrote: > Since in_group_or_capable has been exported, we can use > it to simplify the code when check group and capable. > > Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/posix_acl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/posix_acl.c b/fs/posix_acl.c > index 3f87297dbfdb..6c66a37522d0 100644 > --- a/fs/posix_acl.c > +++ b/fs/posix_acl.c > @@ -715,8 +715,8 @@ int posix_acl_update_mode(struct mnt_idmap *idmap, > return error; > if (error == 0) > *acl = NULL; > - if (!vfsgid_in_group_p(i_gid_into_vfsgid(idmap, inode)) && > - !capable_wrt_inode_uidgid(idmap, inode, CAP_FSETID)) > + if (!in_group_or_capable(idmap, inode, > + i_gid_into_vfsgid(idmap, inode))) > mode &= ~S_ISGID; > *mode_p = mode; > return 0; > -- > 2.34.1 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
