On Mon, Aug 26, 2024 at 12:32:18PM GMT, Christian Brauner wrote: > On Sat, Aug 24, 2024 at 09:27:24AM GMT, Hongbo Li wrote: > > We enable idmapped mounts for bcachefs. Here, we just pass down > > the user_namespace argument from the VFS methods to the relevant > > Fwiw, you're not passing a user namespace, you're passing an idmapping. > > > helpers. > > > > The idmap test in bcachefs is as following: > > I saw that you tested this with xfstests because that has all the > important testing. Below is just really a "ok, that _looks_ like what > we'd expect" kind of test. > > > > > ``` > > 1. losetup /dev/loop1 bcachefs.img > > 2. ./bcachefs format /dev/loop1 > > 3. mount -t bcachefs /dev/loop1 /mnt/bcachefs/ > > 4. ./mount-idmapped --map-mount b:0:1000:1 /mnt/bcachefs /mnt/idmapped1/ > > > > ll /mnt/bcachefs > > total 2 > > drwx------. 2 root root 0 Jun 14 14:10 lost+found > > -rw-r--r--. 1 root root 1945 Jun 14 14:12 profile > > > > ll /mnt/idmapped1/ > > > > total 2 > > drwx------. 2 1000 1000 0 Jun 14 14:10 lost+found > > -rw-r--r--. 1 1000 1000 1945 Jun 14 14:12 profile > > > > Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx> > > > > --- > > Seems good to me, > Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx> Thanks - queued up for 6.12.
