Re: [PATCH 12/16] romfs: Convert romfs_read_folio() to use a folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 15/8/24 22:42, Christian Brauner wrote:
On Wed, Aug 14, 2024 at 08:32:30PM GMT, Matthew Wilcox wrote:
On Mon, Aug 12, 2024 at 02:36:57PM +1000, Greg Ungerer wrote:
Yep, that fixes it.

Christian, can you apply this fix, please?

diff --git a/fs/romfs/super.c b/fs/romfs/super.c
index 68758b6fed94..0addcc849ff2 100644
--- a/fs/romfs/super.c
+++ b/fs/romfs/super.c
@@ -126,7 +126,7 @@ static int romfs_read_folio(struct file *file, struct folio *folio)
  		}
  	}
- buf = folio_zero_tail(folio, fillsize, buf);
+	buf = folio_zero_tail(folio, fillsize, buf + fillsize);
  	kunmap_local(buf);
  	folio_end_read(folio, ret == 0);
  	return ret;

Yep, please see #vfs.fixes. The whole series is already upstream.

Just a heads up, this is still broken in 6.11-rc5.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux