On Fri, Aug 23, 2024 at 10:16:28AM GMT, Christian Brauner wrote: > On Thu, Aug 22, 2024 at 10:17:37AM GMT, Jens Axboe wrote: > > On 8/22/24 9:10 AM, Christian Brauner wrote: > > >> Do we want to add a comment to this effect? I know it's obvious from > > >> sharing with f_task_work, but... > > > > > > I'll add one. > > > > Sounds good. You can add my: > > > > Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> > > > > as well, forgot to mention that in the original reply. > > I think we can deliver 192 bytes aka 3 cachelines. > Afaict we can move struct file_ra_state into the union instead of > f_version. See the appended patch I'm testing now. If that works then > we're down by 40 bytes this cycle. Seems to hold up. I've reorderd things so that no member crosses a cacheline. Patch appended and in vfs.misc.
