Re: [PATCH v3 5/9] fuse: move initialization of fuse_file to fuse_writepages() instead of in callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 23, 2024 at 11:59 AM Josef Bacik <josef@xxxxxxxxxxxxxx> wrote:
>
> On Fri, Aug 23, 2024 at 09:27:26AM -0700, Joanne Koong wrote:
> > Prior to this change, data->ff is checked and if not initialized then
> > initialized in the fuse_writepages_fill() callback, which gets called
> > for every dirty page in the address space mapping.
> >
> > This logic is better placed in the main fuse_writepages() caller where
> > data.ff is initialized before walking the dirty pages.
> >
> > No functional changes added.
> >
> > Signed-off-by: Joanne Koong <joannelkoong@xxxxxxxxx>
>
> You remove the out label in the previous patch, and then add it back here, you
> can probably merge the previous patch and this patch into one patch and it would
> look fine, and reduce the churn a bit.  Thanks,

Gotcha. I'll merge the previous patch (4/9) with this one together in
the next version.

Thanks,
Joanne

>
> Josef





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux