On Thu, 12 Nov 2009, Josef Bacik wrote: > Hello, > > There is a problem where if you have certain audit rules in place > you can hang on mount of a fuse filesystem. If you follow the > instructions here > > https://bugzilla.redhat.com/show_bug.cgi?id=493565#c44 > > it is easy to reproduce. The problem is after the mount request > gets sent, the mounting process gets stuck going off to read xattrs > to satisfy audit's curiosity, and then we get stuck because that > tries to get a request, but can't because the connection is blocked. > This patch fixes the problem, but I'm not entirely sold on it, it's > rather quick and dirty. Basically if we haven't finished the > initialization of the connection just return -EAGAIN. This fixes > the problem, audit seems to be ok with getting that as an error. Why not rather fix audit not to do this? We had a similar problem in SMACK in the past, and my reasoning at the time should apply here as well: calling into filesystem code before it's fully initialized (i.e. mount is finished) is not guaranteed to work for *any* filesystem. Fuse will hang, others may just see silent memory corruption. So NACK, unless there's some fundamental reason why audit can't be properly fixed. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
