On Tue, 03 Nov 2009 15:15:16 +0000
Phillip Lougher <phillip@xxxxxxxxxxxxxxxxxxx> wrote:
>
> BKL is only used in fill_super/put_super. It is safe to remove it.
>
What kernel are you trying to patch here?
Most of your patch is already present in mainline. Against mainline,
this what is left of your patch:
--- a/fs/squashfs/super.c~bkl-remove-bkl-from-squashfs
+++ a/fs/squashfs/super.c
@@ -30,7 +30,6 @@
#include <linux/fs.h>
#include <linux/vfs.h>
#include <linux/slab.h>
-#include <linux/smp_lock.h>
#include <linux/mutex.h>
#include <linux/pagemap.h>
#include <linux/init.h>
@@ -339,8 +338,6 @@ static int squashfs_remount(struct super
static void squashfs_put_super(struct super_block *sb)
{
- lock_kernel();
-
if (sb->s_fs_info) {
struct squashfs_sb_info *sbi = sb->s_fs_info;
squashfs_cache_delete(sbi->block_cache);
@@ -353,8 +350,6 @@ static void squashfs_put_super(struct su
kfree(sb->s_fs_info);
sb->s_fs_info = NULL;
}
-
- unlock_kernel();
}
So someone has decided to remove lots of lock_kernel()'s but chose to
leave the squashfs_put_super() ones behind.
Why did they do that? Your patch effectively asserts that their
decision was incorrect.
So please rethink, update the changelog appropriately and resend.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
