On Tue, Aug 20, 2024 at 09:22:33AM GMT, Christian Brauner wrote: > On Mon, Aug 19, 2024 at 03:20:38PM GMT, NeilBrown wrote: > > inode_dio_wait() is essentially an open-coded version of > > wait_var_event(). Similarly inode_dio_wait_interruptible() is an > > open-coded version of wait_var_event_interruptible(). > > > > If we switch to waiting on the var, instead of an imaginary bit, the > > code is more transparent, is shorter, and we can discard I_DIO_WAKEUP. > > > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > > --- > > Neil, I've sent a patch for this last week already removing > __I_DIO_WAKEUP and it's in -next as > 0009dc756e81 ("inode: remove __I_DIO_WAKEUP"). So you can drop this Today's the day of getting things slightly wrong it seems... 2726a7a8477d8c0 is what I meant.