On Mon, Aug 19, 2024 at 6:53 PM Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:
>
>
> On 8/20/24 2:24 AM, Joanne Koong wrote:
> > Signed-off-by: Joanne Koong <joannelkoong@xxxxxxxxx>
> > ---
> > fs/fuse/file.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> > index f39456c65ed7..63fd5fc6872e 100644
> > --- a/fs/fuse/file.c
> > +++ b/fs/fuse/file.c
> > @@ -1769,8 +1769,7 @@ static void fuse_writepage_free(struct fuse_writepage_args *wpa)
> > kfree(wpa);
> > }
> >
> > -static void fuse_writepage_finish(struct fuse_mount *fm,
> > - struct fuse_writepage_args *wpa)
> > +static void fuse_writepage_finish(struct fuse_writepage_args *wpa)
> > {
> > struct fuse_args_pages *ap = &wpa->ia.ap;
> > struct inode *inode = wpa->inode;
> > @@ -1829,7 +1828,7 @@ __acquires(fi->lock)
> > out_free:
> > fi->writectr--;
> > rb_erase(&wpa->writepages_entry, &fi->writepages);
> > - fuse_writepage_finish(fm, wpa);
> > + fuse_writepage_finish(wpa);
> > spin_unlock(&fi->lock);
> >
> > /* After fuse_writepage_finish() aux request list is private */
> > @@ -1959,7 +1958,7 @@ static void fuse_writepage_end(struct fuse_mount *fm, struct fuse_args *args,
> > fuse_send_writepage(fm, next, inarg->offset + inarg->size);
> > }
> > fi->writectr--;
> > - fuse_writepage_finish(fm, wpa);
> > + fuse_writepage_finish(wpa);
> > spin_unlock(&fi->lock);
> > fuse_writepage_free(wpa);
> > }
>
> I'm afraid an empty commit message will trigger a warning when running
> checkpatch. Otherwise LGTM.
Gotcha, I'll resubmit this with a commit message. Thanks for taking a look.
>
> Reviewed-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx>
>
> --
> Thanks,
> Jingbo
