Re: [RFC] more close_range() fun

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 16 Aug 2024 at 10:19, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> All it takes, and IMO it's simpler that way.

Hey, if it' simpler and gives more natural semantics, I obviously
won't argue against it.

That said, I do hate your "punch_hole" argument. At least make it a
'struct' with start/end, not a random int pointer, ok?

Oh, and can we please make 'dup_fd()' return an error pointer instead
of having that other int pointer argument for the error code?

I wonder why it was done that way - it goes back to 2006 and commit
a016f3389c06 ("unshare system call -v5: unshare files"), it's not like
it's some ancient interface that predates that model.

                Linus




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux