On Mon, Aug 12, 2024 at 06:37:49PM +0200, Bernd Schubert wrote: > Sorry, I had sent out the wrong/old patch file - it doesn't have one change > (handling of already aligned buffers). > Shall I sent v4? The correct version is below > > --- > > From: Bernd Schubert <bschubert@xxxxxxx> > Date: Fri, 21 Jun 2024 11:51:23 +0200 > Subject: [PATCH v3] fuse: Allow page aligned writes > > Write IOs should be page aligned as fuse server > might need to copy data to another buffer otherwise in > order to fulfill network or device storage requirements. > > Simple reproducer is with libfuse, example/passthrough* > and opening a file with O_DIRECT - without this change > writing to that file failed with -EINVAL if the underlying > file system was requiring alignment. > > Required server side changes: > Server needs to seek to the next page, without splice that is > just page size buffer alignment, with splice another splice > syscall is needed to seek over the unaligned area. > > Signed-off-by: Bernd Schubert <bschubert@xxxxxxx> This looks good, Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> Thanks Bernd, Josef