On Mon, Aug 12, 2024 at 12:48:26PM -0400, Kent Overstreet wrote: > > Unlike NOIO or NOFS this is incompatible with NOFAIL allocations > > and thus will lead to kernel crashes. > > No different from passing GFP_NOWAIT to mempoool_alloc(), and we're > trying to get away from passing gfp flags directly for multiple reasons > so we need it. It is very different. Passing GFP_NOWAIT to mempool_alloc affects the piece of code calling mempool_alloc. Setting a GFP_NOWAIT context affects all called code, i.e. all block drivers under the file system, and possible another file system under the loop driver. And none of them expect the consequences of that.