On Wed, Aug 14, 2024 at 6:31 AM Justin Stitt <justinstitt@xxxxxxxxxx> wrote: > > On Tue, Aug 13, 2024 at 3:19 PM Justin Stitt <justinstitt@xxxxxxxxxx> wrote: > > > > Hi, > > > > On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > > > Using strscpy() to read the task comm ensures that the name is > > > always NUL-terminated, regardless of the source string. This approach also > > > facilitates future extensions to the task comm. > > > > Thanks for sending patches replacing str{n}cpy's! > > > > I believe there's at least two more instances of strncpy in trace.c as > > well as in trace_events_hist.c (for a grand total of 6 instances in the > > files you've touched in this specific patch). > > > > It'd be great if you could replace those instances in this patch as well :>) > > > > This would help greatly with [1]. > > > > I just saw that Jinjie Ruan sent replacements for these strncpy's too > and tracked down and replaced an instance of strscpy() that was > present in trace.c but was moved to trace_sched_switch.c during a > refactor. > > They even used the new 2-argument strscpy which is pretty neat. > > See their patch here: > https://lore.kernel.org/all/20240731075058.617588-1-ruanjinjie@xxxxxxxxxx/ + Jinjie That sounds good. Since this change can be handled as a separate patch, I will drop it from the next version and leave it to Jinjie. Please note that Steven might have a better solution for handling task->comm in trace events, so it’s probably best to leave any changes related to trace events to him [0]. [0] https://lore.kernel.org/all/20240603184016.3374559f@xxxxxxxxxxxxxxxxxx/#t -- Regards Yafang