> One general note: IMO you are far too optimistic about the use of __cleanup > extensions; it's _not_ something that we want blindly used all over > the place. In some cases it's fine, but I'm very nervous about the > possibility of people starting to cargo-cult it all over the place. I kept thinking about this a bit as I always value your input on such design decisions. In general I'm very supportive of the cleanup stuff. I know it has its warts and I know that some people really hate it. But I think in general they are an improvement in a lot of scenarios specifically in easing control-flow. Do we run the risk of overuse? Certainly! Will we learn suprising new facts about how broken they may be in some compiler versions? Most likely. Will this mean that we will end up writing some helpers differently so they're easier to use with all that new jazz? Probably. But that's the case with a lot of new things we try. I agree that here using the __free(kfree) annotations was too much but mostly because it could all be done without relying on them. But here it was really just about proving that the idea works so I took a lot of stylistic liberties.
