On Sat, Aug 10, 2024 at 07:00:35PM +0200, Thomas Weißschuh wrote: > The sysctl registration APIs do not need a terminating table entry > anymore and with commit acc154691fc7 ("sysctl: Warn on an empty procname element") > even emit warnings if such a sentinel entry is supplied. > > While at it also remove the mention of "table->de" which was removed in > commit 3fbfa98112fc ("[PATCH] sysctl: remove the proc_dir_entry member for the sysctl tables") > back in 2007. > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> Thanks! Reviewed-by: Kees Cook <kees@xxxxxxxxxx> If you're already poking around at these things, it might also be nice to add full kern-doc for these APIs and structs. -- Kees Cook