"Serge E. Hallyn" <serue@xxxxxxxxxx> writes: > Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx): >> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> >> >> These two functions do 90% of the same work and it doesn't significantly >> obfuscate the function to allow both the parent dir and the name to change >> at the same time. So merge them together to simplify maintenance, and >> increase testing. >> >> Acked-by: Tejun Heo <tj@xxxxxxxxxx> >> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx> > > Based on just this patchset it seems sysfs_rename() could be static, > but since it isn't static I assume your later patchset will use it > outside fs/sysfs/dir.c? To implement sysfs_rename_link, but that is too much to digest/review/push all at once. I have a snapshot of my development tree up on kernel.org if you are interested. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html