tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.fd head: 9d58a36411c167b4126de90e5fe844270b858082 commit: f3270beef0d85432783be702bb9509879415e747 [3/39] struct fd: representation change config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240810/202408102233.hZjt9tS1-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240810/202408102233.hZjt9tS1-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408102233.hZjt9tS1-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/kernel_read_file.h:5, from include/linux/security.h:26, from include/linux/perf_event.h:62, from include/linux/perf/riscv_pmu.h:12, from arch/riscv/include/asm/kvm_vcpu_pmu.h:12, from arch/riscv/include/asm/kvm_host.h:23, from arch/riscv/kernel/asm-offsets.c:14: include/linux/file.h: In function 'fdput': >> include/linux/file.h:60:34: error: expected ')' before ';' token 60 | fput(fd_file(fd)); | ~ ^ | ) include/linux/file.h:60:35: error: expected ';' before '}' token 60 | fput(fd_file(fd)); | ^ | ; 61 | } | ~ include/linux/file.h: In function 'fdput_pos': include/linux/file.h:94:43: error: expected ')' before ';' token 94 | __f_unlock_pos(fd_file(f)); | ~ ^ | ) include/linux/file.h:95:18: error: expected ';' before '}' token 95 | fdput(f); | ^ | ; 96 | } | ~ make[3]: *** [scripts/Makefile.build:117: arch/riscv/kernel/asm-offsets.s] Error 1 make[3]: Target 'prepare' not remade because of errors. make[2]: *** [Makefile:1193: prepare0] Error 2 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:224: __sub-make] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:224: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +60 include/linux/file.h 254beb4164efec Al Viro 2024-05-31 56 a5b470ba06aa3f Al Viro 2012-08-27 57 static inline void fdput(struct fd fd) a5b470ba06aa3f Al Viro 2012-08-27 58 { f3270beef0d854 Al Viro 2024-05-31 59 if (fd.word & FDPUT_FPUT) 254beb4164efec Al Viro 2024-05-31 @60 fput(fd_file(fd)); a5b470ba06aa3f Al Viro 2012-08-27 61 } a5b470ba06aa3f Al Viro 2012-08-27 62 :::::: The code at line 60 was first introduced by commit :::::: 254beb4164efececb3e7b85019e0102c36e86e62 introduce fd_file(), convert all accessors to it. :::::: TO: Al Viro <viro@xxxxxxxxxxxxxxxxxx> :::::: CC: Al Viro <viro@xxxxxxxxxxxxxxxxxx> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki