On Fri, 2024-08-09 at 16:55 +0200, Christian Brauner wrote: > On Fri, Aug 09, 2024 at 09:39:43AM GMT, Jeff Layton wrote: > > When fetching the ctime's nsec value for a stat-like operation, do > > a > > simple fetch first and avoid the atomic_fetch_or if the flag is > > already > > set. > > > > Suggested-by: Mateusz Guzik <mjguzik@xxxxxxxxx> > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > > --- > > I'm running tests on this now, but I don't expect any problems. > > > > This is based on top of Christian's vfs.mgtime branch. It may be > > best to > > squash this into 6feb43ecdd8e ("fs: add infrastructure for > > multigrain > > timestamps"). > > Squashed it. Can you double-check that things look correct? One minor issue in fill_mg_cmtime: -------------8<----------------- if (!(stat->ctime.tv_nsec & I_CTIME_QUERIED)) stat->ctime.tv_nsec = ((u32)atomic_fetch_or(I_CTIME_QUERIED, pcn)); trace_fill_mg_cmtime(inode, &stat->ctime, &stat->mtime); stat->ctime.tv_nsec &= ~I_CTIME_QUERIED; } -------------8<----------------- I'd swap the last two lines of the function. We print the ctime in the tracepoint as a timestamp, so if the QUERIED bit is present it's going to look funny. We _know_ that it's flagged after this function, so leaving it set is not terribly helpful. -- Jeff Layton <jlayton@xxxxxxxxxx>