Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx): > "Serge E. Hallyn" <serue@xxxxxxxxxx> writes: > > > Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx): > >> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > >> > >> Currently sysfs updates the timestamps on the vfs directory > >> inode when we create or remove a directory entry but doesn't > >> update the cached copy on the sysfs_dirent, fix that oversight. > > > > confused... why not do this in sysfs_addrm_finish()? > > > > I guess you'd have to do at it at top before dropping sysfs_mutex > > so it wouldn't be as pretty as I was thinking, but at least you > > could just do it once. > > Well sysfs_addrm_finish doesn't really know if you did anything. Oh right - well it used to through cnt right? but not after your last patch. > Beyond that my ultimate goal is to kill sysfs_addrm_start and > sysfs_addrm_finish. Of course that requires fixing all of the > sysfs users that depend on the impossible to get right recursive > directory removal in sysfs, so it is not the subject of this patchset. I didn't see the patch nixing inode->i_mtime (and cnt) changing from sysfs_addrm_finish() until after responding. Got it now. Acked-by: Serge Hallyn <serue@xxxxxxxxxx> -serge -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
