On Tue, 6 Aug 2024 at 11:57, Solar Designer <solar@xxxxxxxxxxxx> wrote: > > As (I assume it was) expected, these changes broke out-of-tree modules. It was presumably not expected - but for the simple reason that no kernel developer should spend one single second worrying about out-of-tree modules. It's simply not a concern - never has been, and never will be. Now, if some out-of-tree module is on the cusp of being integrated, and is out-of-tree just because it's not quite ready yet, that would maybe be then a case of "hey, wait a second". But no. We are not going to start any kind of feature test macros for external modules in general. Linus