On Tue, 6 Aug 2024 at 09:02, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > -static int proc_readfd(struct file *file, struct dir_context *ctx) > +static int proc_fd_iterate_shared(struct file *file, struct dir_context *ctx) I think the "proc_fd_iterate" part is great. The "shared" part I'm not super-excited about, simply because we finally got rid of the non-shared 'iterate' function entirely last year, and so the "_shared" part is pure historical naming. In fact, I was hoping we'd do an automated rename at some point. Maybe not to "iterate" (too generic a name), but something like "iterate_dir" or something would avoid the now pointless "shared" thing. Linus