Re: [PATCH v4 bpf-next 1/3] bpf: introduce new VFS based BPF kfuncs

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Wed, Jul 31, 2024 at 6:16 PM Song Liu <song@xxxxxxxxxx> wrote:
>
> > --- /dev/null
> > +++ b/fs/bpf_fs_kfuncs.c
> > @@ -0,0 +1,127 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Copyright (c) 2024 Google LLC. */
> > +
> > +#include <linux/bpf.h>
> > +#include <linux/btf.h>
> > +#include <linux/btf_ids.h>
> > +#include <linux/dcache.h>
> > +#include <linux/err.h>
> > +#include <linux/fs.h>
> > +#include <linux/file.h>
> > +#include <linux/init.h>
> > +#include <linux/mm.h>
> > +#include <linux/path.h>
> > +#include <linux/sched.h>
>
> It appears we don't need to include all these headers. With my
> daily config, #include <linux/bpf.h> alone is sufficient.

In general it's a good idea to include necessary headers and
not rely on implicit recursive includes, but in this case the
list is indeed excessive.
I trimmed it a bit while applying.

Thanks everyone!