On Fri, Aug 02, 2024 at 10:44:15PM +0800, Lizhi Xu wrote:
> On Fri, 2 Aug 2024 14:52:14 +0100, Al Viro wrote:
> > > + ERROR("Wrong i_size %d!\n", inode->i_size);
> > > + return -EINVAL;
> > > + }
> >
> > ITYM something like
> I do not recommend this type of code, as it would add unnecessary calls
> to le32_o_cpu compared to directly using i_size.
> > if (le32_to_cpu(sqsh_ino->symlink_size) > PAGE_SIZE) {
> > ERROR("Corrupted symlink\n");
> > return -EINVAL;
> > }
You do realize that it's inlined, right? Seriously, compare the
generated code...
