On Thu 01-08-24 19:19:50, Jan Kara wrote: > On Thu 25-07-24 14:19:44, Josef Bacik wrote: > > From: Amir Goldstein <amir73il@xxxxxxxxx> > > > > FANOTIFY_PIDFD_INFO_HDR_LEN is not the length of the header. > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > --- > > fs/notify/fanotify/fanotify_user.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > > index 3a7101544f30..5ece186d5c50 100644 > > --- a/fs/notify/fanotify/fanotify_user.c > > +++ b/fs/notify/fanotify/fanotify_user.c > > @@ -119,7 +119,7 @@ struct kmem_cache *fanotify_perm_event_cachep __ro_after_init; > > #define FANOTIFY_EVENT_ALIGN 4 > > #define FANOTIFY_FID_INFO_HDR_LEN \ > > (sizeof(struct fanotify_event_info_fid) + sizeof(struct file_handle)) > > -#define FANOTIFY_PIDFD_INFO_HDR_LEN \ > > +#define FANOTIFY_PIDFD_INFO_LEN \ > > OK, but then FANOTIFY_FID_INFO_HDR_LEN should be renamed as well? Or what's > the difference? Ah, never mind. I've realized that to FID we indeed need to add the file handle length. So there is a difference and the cleanup makes sense. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
