Acked-by: Coly Li <coly.li@xxxxxxx>
On 2009年11月02日 18:04, Jan Blunck Wrote:
> BKL is only used in fill_super. It is safe to remove it.
>
> Signed-off-by: Jan Blunck <jblunck@xxxxxxx>
> ---
> fs/cramfs/inode.c | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
> index 13e696a..dd3634e 100644
> --- a/fs/cramfs/inode.c
> +++ b/fs/cramfs/inode.c
> @@ -227,15 +227,11 @@ static int cramfs_fill_super(struct super_block *sb, void *data, int silent)
> struct cramfs_sb_info *sbi;
> struct inode *root;
>
> - lock_kernel();
> -
> sb->s_flags |= MS_RDONLY;
>
> sbi = kzalloc(sizeof(struct cramfs_sb_info), GFP_KERNEL);
> - if (!sbi) {
> - unlock_kernel();
> + if (!sbi)
> return -ENOMEM;
> - }
> sb->s_fs_info = sbi;
>
> /* Invalidate the read buffers on mount: think disk change.. */
> @@ -312,12 +308,10 @@ static int cramfs_fill_super(struct super_block *sb, void *data, int silent)
> iput(root);
> goto out;
> }
> - unlock_kernel();
> return 0;
> out:
> kfree(sbi);
> sb->s_fs_info = NULL;
> - unlock_kernel();
> return -EINVAL;
> }
>
--
Coly Li
SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
