On Tue 30-07-24 00:18:13, Pavel Reichl wrote:
> Error: RESOURCE_LEAK (CWE-772):
> quota-4.09/quotaio_xfs.c:162:2: alloc_fn: Storage is returned from allocation function "get_empty_dquot".
> quota-4.09/quotaio_xfs.c:162:2: var_assign: Assigning: "dquot" = storage returned from "get_empty_dquot()".
> quota-4.09/quotaio_xfs.c:180:4: leaked_storage: Variable "dquot" going out of scope leaks the storage it points to.
>
> Signed-off-by: Pavel Reichl <preichl@xxxxxxxxxx>
Thanks for the fix! Applied.
Honza
> ---
> quotaio_xfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/quotaio_xfs.c b/quotaio_xfs.c
> index 2df27b5..5446bc5 100644
> --- a/quotaio_xfs.c
> +++ b/quotaio_xfs.c
> @@ -174,6 +174,7 @@ static struct dquot *xfs_read_dquot(struct quota_handle *h, qid_t id)
> * zeros. Otherwise return failure.
> */
> if (errno != ENOENT) {
> + free(dquot);
> return NULL;
> }
> }
> --
> 2.45.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
