Hi, On Fri, May 03, 2024 at 02:01:37PM +0100, Joey Gouly wrote: > Now that PKEYs support has been implemented, enable it for CPUs that > support S1POE. > > Signed-off-by: Joey Gouly <joey.gouly@xxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: Will Deacon <will@xxxxxxxxxx> > Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx> > --- > arch/arm64/include/asm/pkeys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h > index a284508a4d02..3ea928ec94c0 100644 > --- a/arch/arm64/include/asm/pkeys.h > +++ b/arch/arm64/include/asm/pkeys.h > @@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, > > static inline bool arch_pkeys_enabled(void) > { > - return false; > + return system_supports_poe(); > } Nit: maybe push this later in the series, at least to after the POE/PIE patch, since pkeys won't work right otherwise on PIE-enabled platforms? (I know it makes no difference without final Kconfig update, but it feels more logical.) [...] Cheers ---Dave