Re: [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/30/2009 12:53 AM, Martin K. Petersen wrote:
"Doug" == Douglas Gilbert<dgilbert@xxxxxxxxxxxx>  writes:
Doug>  And if both are supported by the logical unit, the patch prefers
Doug>  UNMAP?

Yes.

SBC states that if the device reports MAXIMUM UNMAP LBA COUNT>  1 and
MAXIMUM UNMAP DESCRIPTOR COUNT>  1 then the device supports UNMAP.  And
in that case that's what I'll issue.  In all other cases I'll send out
WRITE SAME(16).  I believe that approach is what's currently considered
best practice.

This sounds like the correct thing to do.

We should at the same time try to unify the file system mount options so we roll out the testing in a careful way.

Specifically, I would suggest that we default to "not" issuing discards by default and that we try to use the same mount option for any file system that supports barrier discards. My worry is that we will fry SSD's (like the reported issues with the Intel SSD's and Windows 7) or have horrific performance on arrays that are not tuned for fine grained discards :-)

Ric

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux