Re: [PATCH] vfs: Fix potential circular locking through setxattr() and removexattr()

[David Howells <dhowells@xxxxxxxxxx>]

Jan Kara <jack@xxxxxxx> wrote:

> > +	error = strncpy_from_user(kname, name, sizeof(kname));
> > +	if (error == 0 || error == sizeof(kname))
> > +		error = -ERANGE;
> > +	if (error < 0)
> > +		return error;
> 
> Missing fdput() here.

Thanks.  I think Christian is altering the patch to use auto-destruction
constructs (CLASS()).

David